[BitPim-devel] Version History updates for LG VX 6100

[John O'Shaughnessy]

[aladdin:bitpim/bitpim/help] osh% cvs diff versionhistory.htd
Index: versionhistory.htd
===================================================================
RCS file: /cvsroot/bitpim/bitpim/help/versionhistory.htd,v
retrieving revision 1.198
diff -r1.198 versionhistory.htd
24a25,29

<li><b>LG VX6100</b> Underscore character "_" now supported in ringer

and

wallpaper file names. Number of ringers allowed increased from 30 to

60.

Number of wallpaper allowed increased from 30 to 60. Number of camera
images allowed increased from 20 to 60.

[Roger Binns]

<li><b>LG VX6100</b> Underscore character "_" now supported in ringer

and

wallpaper file names. Number of ringers allowed increased from 30 to

60.

Number of wallpaper allowed increased from 30 to 60. Number of camera
images allowed increased from 20 to 60.

Those changes aren't in the code. Did I miss a patch?

Roger

[Roger Binns]

Post by Roger Binns

<li><b>LG VX6100</b> Underscore character "_" now supported in ringer

and

wallpaper file names. Number of ringers allowed increased from 30 to

60.

Number of wallpaper allowed increased from 30 to 60. Number of camera
images allowed increased from 20 to 60.

Those changes aren't in the code. Did I miss a patch?

I should have mentioned that I was going to make them, but need the new offset
numbers otherwise the number ranges overlap.

Roger

[John O'Shaughnessy]

Post by Roger Binns

Post by Roger Binns
Those changes aren't in the code. Did I miss a patch?

I should have mentioned that I was going to make them, but need the new offset
numbers otherwise the number ranges overlap.

Did this not come across?

I've modified the offsets to allow for the larger ranges.

John

[aladdin:Dev/bitpim/bitpim] osh% cvs diff com_lgvx6100.py
Index: com_lgvx6100.py
===================================================================
RCS file: /cvsroot/bitpim/bitpim/com_lgvx6100.py,v
retrieving revision 1.3
diff -r1.3 com_lgvx6100.py
48,51c48,51
< ( 50, "download/dloadindex/brewImageIndex.map", "brew/shared",
"images", 30) ,
< ( 100, "download/dloadindex/mmsImageIndex.map", "brew/shared/mms",
"mms", 20),
< ( 220, "download/dloadindex/mmsDrmImageIndex.map",
"brew/shared/mms/d", "drm", 20),
< ( 130, None, None, "camera", 20) # nb camera must be last
---

Post by Roger Binns
( 50, "download/dloadindex/brewImageIndex.map", "brew/shared",

"images", 60) ,

Post by Roger Binns
( 110, "download/dloadindex/mmsImageIndex.map", "brew/shared/mms",

"mms", 60),

Post by Roger Binns
( 170, "download/dloadindex/mmsDrmImageIndex.map",

"brew/shared/mms/d", "drm", 20),

Post by Roger Binns
( 200, None, None, "camera", 60) # nb camera must be last

56c56
< ( 50, "download/dloadindex/brewRingerIndex.map",
"user/sound/ringer", "ringers", 30),
---

Post by Roger Binns
( 50, "download/dloadindex/brewRingerIndex.map", "user/sound/ringer",

"ringers", 60),
105c105
<
WALLPAPER_FILENAME_CHARS="ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwx
yz0123456789 ."
---
WALLPAPER_FILENAME_CHARS="ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz01
23456789_ ."
109c109
<
RINGTONE_FILENAME_CHARS="ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxy
z0123456789 ."
---
RINGTONE_FILENAME_CHARS="ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz012
3456789_ ."

[Roger Binns]

Post by John O'Shaughnessy
Did this not come across?

They hadn't been applied before. I may have forgotten to apply the
patches or something earlier. Sorry.

I do recommend either checking the code in CVS or subscribing to
the cvs checkins list to see what actually ends up in the code.

Also please use the unified diff format as it is way easier to
read. I'd suggest something like this in your $HOME/.cvsrc:

cvs -z6 -q
update -dP
diff -u

Post by John O'Shaughnessy
I've modified the offsets to allow for the larger ranges.

Did you manage to verify the offsets, or are they currently still
best guesses?

Thanks for the updates!

Roger

[John O'Shaughnessy]

Post by Roger Binns

Post by John O'Shaughnessy
Did this not come across?

They hadn't been applied before. I may have forgotten to apply the
patches or something earlier. Sorry.

My patch was just sent minutes earlier (around 10 CST last night), no
apologies needed.

Post by Roger Binns
Also please use the unified diff format as it is way easier to
cvs -z6 -q
update -dP
diff -u

Thanks - I'll do that.

Post by Roger Binns

Post by John O'Shaughnessy
I've modified the offsets to allow for the larger ranges.

Did you manage to verify the offsets, or are they currently still
best guesses?

Still best guesses. Verification is still on my to-do list.

John