[BitPim-devel] Re: [bitpim-cvs-checkins] bitpim bpcalendar.py,1.30 ,1.31 com_lgvx4650.py,1.1,1.2 p_lgvx4650.p,1.1,1.2 p_lgvx4650.py,1.1,1 .2

[Joe Pham]

The VX4400 onwards, except the VX8100 use this format. Can you
please rationalize all the code and only have it in one place?
(You'll find the same constants listed in com_lgvx4400.py)

Yes, I noticed that also, but was not sure what else is similar among the other LGs. Since all other LG codes subclass from the 4400, would it make sense to put the common code there, or in com_lg?

-Joe Pham

[Roger Binns]

Post by Joe Pham
Yes, I noticed that also, but was not sure what else is similar
among the other LGs. Since all other LG codes subclass from the
4400, would it make sense to put the common code there, or in com_lg?

In this case, moving the code to com_lg is fine. The TM520 is
a previous generation, but everything starting with the VX4400 onwards
is roughly similar.

Roger