Discussion:
[BitPim-devel] new wallpaper stuff committed - all phone profiles need to be updated
Roger Binns
2005-03-01 08:51:51 UTC
Permalink
I have committed the new wallpaper code. When adding new
image files you can select what origin to use, crop the
image and choose whatever area you want while maintaining
aspect ration. You can also choose the target for your image.

An origin is a distinct storage area on the phone. For example
some phones only have one, while others can have several. Some
you may read and write from while others may only be read (eg
camera).

A target is what the user intends to do with the image. Each
target can have different dimensions and format. For example
the dimensions of an image intended for fullscreen startup
will be larger than those used as wallpaper as the latter
leaves space for menu bars and status lines.

You will need to add two methods to your profile. One is
GetImageOrigins() which returns the origins you can write to
on the phone.

The second is GetTargetsForImageOrigin() which returns the
targets for the specified origin. There is code and comments
in com_phone and an example usage in com_lgvx6000.py.

At some point I will soliciting image dimensions and format
information on bitpim-user. This will give those users
who care about image sizes to tell us exactly what the
correct sizes for various targets are.

There are still some rough areas in all this to work through,
but we now have a good start.

Roger
d***@netzero.net
2005-03-02 06:13:03 UTC
Permalink
Roger, I implemented this for the Samsung A650, which supports bmp and png at various screen resolutions, and it works very well. Some observations:

1. Up to this point, all of the images related origin has been set to 'wallpapers', which isn't one of the entries in the default Phone.stockimageorigins. Are you encouraging us to move away from the 'wallpapers' origin to something like 'images' instead? For now, taking the path of least resistance, I just added a 'wallpapers' entry into stockimageorigins to make it work.

2. Do you plan to add an option to allow users to add unprocessed/unmodified images (taking their own risks at the same time)?

-Joe Pham



______________________________________________________________________
Speed up your surfing with NetZero HiSpeed.
Now includes pop-up blocker!
Only $14.95/month -visit http://www.netzero.com/surf to sign up today!
Roger Binns
2005-03-02 07:25:17 UTC
Permalink
Post by d***@netzero.net
1. Up to this point, all of the images related origin has been set
to 'wallpapers', which isn't one of the entries in the default
Phone.stockimageorigins. Are you encouraging us to move away from the
'wallpapers' origin to something like 'images' instead? For now, taking
the path of least resistance, I just added a 'wallpapers' entry into
stockimageorigins to make it work.
I would like to unify what we use, especially so that you can load
from one phone model and save to another. images is a better term
since wallpaper is really a target.
Post by d***@netzero.net
2. Do you plan to add an option to allow users to add
unprocessed/unmodified images (taking their own risks at the same time)?
Yes. It will probably be something like holding down the
shift or control keys when adding.

Roger
d***@netzero.net
2005-03-02 06:38:28 UTC
Permalink
One more comment: it'd be nice if the target info is included in either 'wallpapers' or 'wallpaper-index' dict being sent to the phone module.

-Joe Pham



______________________________________________________________________
Speed up your surfing with NetZero HiSpeed.
Now includes pop-up blocker!
Only $14.95/month -visit http://www.netzero.com/surf to sign up today!
Roger Binns
2005-03-02 07:32:53 UTC
Permalink
Post by d***@netzero.net
One more comment: it'd be nice if the target info is included in
either 'wallpapers' or 'wallpaper-index' dict being sent to the
phone module.
Why?

In general if you can tell the images apart or put them in
different areas of the phone storage depending on purpose
then those are origins not targets.

Consider what the level of granularity is when reading images
back off the phone.

Roger
d***@netzero.com
2005-03-02 16:38:28 UTC
Permalink
Post by d***@netzero.net
One more comment: it'd be nice if the target info is included in
either 'wallpapers' or 'wallpaper-index' dict being sent to the
phone module.
Why?
Because on the A670, an image of the same resolution and format could go to 2 different phone locations based on the target type. On the read back, they all have "wallpapers" origin.

-Joe Pham



______________________________________________________________________
Speed up your surfing with NetZero HiSpeed.
Now includes pop-up blocker!
Only $14.95/month -visit http://www.netzero.com/surf to sign up today!
Roger Binns
2005-03-02 17:11:02 UTC
Permalink
Post by d***@netzero.com
Because on the A670, an image of the same resolution and format could
go to 2 different phone locations based on the target type.
Then those are two different origins. As I said, an origin is a distinct
storage area on the phone.

Roger
d***@netzero.com
2005-03-02 17:27:35 UTC
Permalink
Post by Roger Binns
Then those are two different origins.
I certainly could do that. At the time, I just looked at the stock origins and targets, and it seemd a natural fit: origin: 'images', target: 'wallpaper' and 'pictureid'. I guess I could try 'wallpaper images' and 'picture id images' for origins.

-Joe Pham



______________________________________________________________________
Speed up your surfing with NetZero HiSpeed.
Now includes pop-up blocker!
Only $14.95/month -visit http://www.netzero.com/surf to sign up today!
Roger Binns
2005-03-02 18:11:51 UTC
Permalink
Post by d***@netzero.com
I certainly could do that. At the time, I just looked at the
'images', target: 'wallpaper' and 'pictureid'. I guess I could
try 'wallpaper images' and 'picture id images' for origins.
The labels are for the benefit of the users. It is *way* more
important that the number of origins in a profile matches the
number of origins on the phone. The labels are cosmetic.
However we should have consistency so that importing from
one phone model and exporting to another works, which is
why inventing new labels is a bad thing.

Roger
d***@netzero.com
2005-03-02 18:32:15 UTC
Permalink
However we should have consistency so that importing from one phone >model and exporting to another works
So are 'wallpapers' and 'pictureid' generic enough that they could be added to the stock origins list?

-Joe Pham



______________________________________________________________________
Speed up your surfing with NetZero HiSpeed.
Now includes pop-up blocker!
Only $14.95/month -visit http://www.netzero.com/surf to sign up today!
d***@netzero.net
2005-03-07 16:43:26 UTC
Permalink
Post by Roger Binns
I would like to unify what we use, especially so that you can load
from one phone model and save to another. images is a better term
since wallpaper is really a target.
Roger, the wallpaper module currently does not seem to handle data with any origin other than 'wallpapers'. To make this build, I'm adding 'wallpapers' into stockorigins until the wallpaper module is straightened out. Please let me know if this is a bad idea.

-Joe Pham


______________________________________________________________________
Speed up your surfing with NetZero HiSpeed.
Now includes pop-up blocker!
Only $14.95/month -visit http://www.netzero.com/surf to sign up today!
d***@netzero.net
2005-03-07 17:08:50 UTC
Permalink
Never mind! Global search/replace error! :-)

-Joe Pham



______________________________________________________________________
Speed up your surfing with NetZero HiSpeed.
Now includes pop-up blocker!
Only $14.95/month -visit http://www.netzero.com/surf to sign up today!
Loading...