[BitPim-devel] A minor bug

[Adit Panchal]

I found an extra copy of the comparing of urls in mergefields. I don't
think it is needed, since it would get skipped anyways.

Also, I made a new watermark for the ringers tab. I am not sure if it
is good though, but I think it shows up better on the Mac. I tested it
on my Windows box and it looks fine as well. The image is attached. If
anyone wants to tweak the image, I can attach the original.

Furthermore, I made new toolbar icons for the add and delete buttons
for the ringers tab. Before I send those, I need to write a bit of code
to allow for the images to be changed for each tab. If you want to take
a look at the buttons, I can attach them.

Adit

RCS file: /cvsroot/bitpim/bitpim/phonebook.py,v
retrieving revision 1.125
diff -u -r1.125 phonebook.py
--- phonebook.py 6 Jan 2005 04:56:07 -0000 1.125
+++ phonebook.py 16 Jan 2005 19:12:57 -0000
@@ -2088,8 +2088,6 @@
score+=comparenames(s,a)
elif key=="numbers":
score+=comparenumbers(s,a)
- elif key=="urls":
- score+=comparefields(s,a,"url")
elif key=="emails":
score+=comparefields(s,a,"email")
elif key=="urls":

[Roger Binns]

Post by Adit Panchal
I found an extra copy of the comparing of urls in mergefields. I don't
think it is needed, since it would get skipped anyways.

I've removed it.

Post by Adit Panchal
Also, I made a new watermark for the ringers tab. I am not sure if it
is good though, but I think it shows up better on the Mac.

What do mean by "better"? Is this an LCD vs CRT issue, or the default
colour profiles or something?

Once I get my Mac I'll have a look into this, since I'll have all 3
operating systems using the same CRT monitor and can also check on
Windows on a laptop for an LCD screen.

Post by Adit Panchal
Furthermore, I made new toolbar icons for the add and delete buttons
for the ringers tab. Before I send those, I need to write a bit of code
to allow for the images to be changed for each tab. If you want to take
a look at the buttons, I can attach them.

The best thing to do is hook them into wx.ArtProvider as that is what
we use now to get the images. It looks like both Linux and Windows are
using 32x32.

Roger