Discussion:
[BitPim-devel] Re: [bitpim-cvs-checkins] SF.net SVN: bitpim: [2922 ] trunk/bitpim/src
Joe Pham
2006-03-16 21:53:44 UTC
Permalink
Isn't the (Cingular) bit in the name redundant?
Yes, it is. I'll remove the carrier's name from the model's name.

-Joe Pham




_____________________________________________________________________
Call Anyone, Anytime, Anywhere in the World - FREE!
Free Internet calling from NetZero Voice
Visit http://www.netzerovoice.com today!
Roger Binns
2006-03-19 05:36:22 UTC
Permalink
Post by Joe Pham
Isn't the (Cingular) bit in the name redundant?
Yes, it is. I'll remove the carrier's name from the model's name.
There may still be a problem. If the same model is
supported twice but with different carriers, then
the key won't be unique (imagine a vx4400 on vzw and
sprint). You can fix that by changing the structure
from a dict into a list and then constructing a dict
from the list when you add the carrier names.

There is also a problem with the file selection dialog.
The columns should be forced to be wider. On Mac they
are undreadable.

The screenshot also demonstrates another problem. I
happen to know my VX4400 is on Verizon Wireless but
selecting them as a carrier first means I can't find
the phone! I think you'll need to do something like
consider phones that have no carrier listed as being
with all carriers. It may also be a good idea to
change the 'carrier' key in the data structure to
be a list. That way we could list the carriers for
each model that we know work.

I also don't see the distinction between unknown and
other as carriers or handset manufacturers.

Roger
Joe Pham
2006-03-19 20:35:45 UTC
Permalink
If the same model is supported twice but with different carriers,
then the key won't be unique (imagine a vx4400 on vzw and
sprint).
This will be taken care of by your later suggestion: make the 'carrier' data structure into a list.
The columns should be forced to be wider.
It looked fine on Windows. On the Mac, the problem appears to be that the width of the LB does not account for the VScroll. I'll turn on the Vscroll regardless.
I think you'll need to do something like consider phones that have
no carrier listed as being with all carriers.
I see your point. But since we should know the carriers of each and every phone BitPim supports, I think it'd be better if we all could provide the carrier info. Having a phone listed as being with all carriers could be misleading.
may also be a good idea to change the 'carrier' key in the data
structure to be a list.
Agreed.
I also don't see the distinction between unknown and other as
carriers or handset manufacturers.
Agreed. I'll get rid of other.

-Joe Pham




_____________________________________________________________________
Call Anyone, Anytime, Anywhere in the World - FREE!
Free Internet calling from NetZero Voice
Visit http://www.netzerovoice.com today!
Roger Binns
2006-03-19 21:47:32 UTC
Permalink
Post by Joe Pham
I also don't see the distinction between unknown and other as
carriers or handset manufacturers.
Agreed. I'll get rid of other.
I'd dump unknown. There is a carrier and the user happens to
know exactly who it is. So it is known to the user and unknown
to us as developers, but they are the ones using the interface.

It also sounds like we should make some sort of effort in the
autodetect routines to also detect the carrier. In the case of Verizon
there will be Get-It-Now information somewhere.

Roger

Loading...