Roger Binns
2004-07-29 07:06:45 UTC
I just made this change which affects all phones when doing a
directory listing of the root of the filesystem. It should
fix the VX7000 issue. I tested on the VX4400, VX6000 and
CDM8900 and they were all happy with the change.
The code used to list the root directory by listing "/".
Now it just lists "".
Can everyone who doesn't have one of the phones listed above
please check? In particular you should check that you
get the same number of files/directories listed of the root
directory. A nice test is to make a zip backup and verify
it completes.
directory listing of the root of the filesystem. It should
fix the VX7000 issue. I tested on the VX4400, VX6000 and
CDM8900 and they were all happy with the change.
The code used to list the root directory by listing "/".
Now it just lists "".
Can everyone who doesn't have one of the phones listed above
please check? In particular you should check that you
get the same number of files/directories listed of the root
directory. A nice test is to make a zip backup and verify
it completes.
com_brew.py
don't use "/" for listing root directory - use empty string instead
Index: com_brew.py
===================================================================
RCS file: /cvsroot/bitpim/bitpim/com_brew.py,v
retrieving revision 1.25
retrieving revision 1.26
diff -u -d -r1.25 -r1.26
--- com_brew.py 27 Jun 2004 09:37:35 -0000 1.25
+++ com_brew.py 29 Jul 2004 07:02:06 -0000 1.26
@@ -145,8 +145,7 @@
req=p_brew.listfilerequest()
req.entrynumber=i
- if len(dir): req.dirname=dir
- else: req.dirname="/"
+ req.dirname=dir
res=self.sendbrewcommand(req,p_brew.listfileresponse)
results[res.filename]={ 'name': res.filename,
'type': 'file', 'size': res.size }
Rogerdon't use "/" for listing root directory - use empty string instead
Index: com_brew.py
===================================================================
RCS file: /cvsroot/bitpim/bitpim/com_brew.py,v
retrieving revision 1.25
retrieving revision 1.26
diff -u -d -r1.25 -r1.26
--- com_brew.py 27 Jun 2004 09:37:35 -0000 1.25
+++ com_brew.py 29 Jul 2004 07:02:06 -0000 1.26
@@ -145,8 +145,7 @@
req=p_brew.listfilerequest()
req.entrynumber=i
- if len(dir): req.dirname=dir
- else: req.dirname="/"
+ req.dirname=dir
res=self.sendbrewcommand(req,p_brew.listfileresponse)
results[res.filename]={ 'name': res.filename,
'type': 'file', 'size': res.size }