Discussion:
[Bitpim-devel] Re: [bitpim-cvs-checkins] bitpim p_samsungscha620.p,1.3,1.4
Roger Binns
2004-12-09 06:06:21 UTC
Permalink
* SAMSTRING {'quotechar': None, 'terminator': ord(' '), 'constant': 'PBOKR:'}
The ord(' ') seems yucky? Can't the terminator be stored as a string?
(You could even allow it to be a list of characters that could be
terminator).

Roger
Stephen Wood
2004-12-09 14:59:57 UTC
Permalink
I know, but I modeled quotechar and terminator after STRING's pad and
terminator (which would need ord too if any uses of them were other
than None, 0, or the default.) If I modifiy the code to allow a
multicharacter terminator string (something not yet needed), I will
change the keyword to something unique like 'terminatorstring'.

Stephen
Post by Roger Binns
* SAMSTRING {'quotechar': None, 'terminator': ord(' '), 'constant': 'PBOKR:'}
The ord(' ') seems yucky? Can't the terminator be stored as a string?
(You could even allow it to be a list of characters that could be
terminator).
Roger
Roger Binns
2004-12-09 16:19:31 UTC
Permalink
Post by Stephen Wood
I know, but I modeled quotechar and terminator after STRING's pad and
terminator (which would need ord too if any uses of them were other
than None, 0, or the default.)
Your assumption that the existing code is a good model isn't necessarily
correct :-)

Roger

Loading...