Roger,
com_lgvx4400.py
I have looked at this again and I screwed up on this :(. I did not mean to
change the comment or the unset alarm.
I also found out the changes I made did not work after some more testing.
The 8100 changed the meaning of the speeddial PACKET slighlty. The second
field 'number' now represents the numbertype instead of the numberindex.
This means that you have to match with the numbertype in the phonebook entry
instead of the position index. I scrapped my original change and introduced
a new one which I tested more heavily, this allows the phone implementation
to choose the meaning of the 'number' field in the speeddial PACKET using a
new protocol paramter SPEEDDIALINDEX, this is set to 0 for the old meaning
and 1 for the new vx8100 meaning. I felt a generic change was better than
overriding the phonebook reading functions in the 8100 class, this way other
new phones that work this way can take advantage of common code.
com_lgvx8100.py
The file really is called newschedule.dat. I'm not sure if it is similar to
the other phones as I have not looked at one of them, although the
scheduleevent PACKET is very different from the 6100 and 4400. I don't know
what the analyser format is, is it documented?, I will write a desription of
the calender based on what I have observed in the phone once I figure this
out, where would this be stored?
The vibrate is a flag (1 bit), it can be set independently of the ringtone
for a given alarm. It would be great to add a new field to the calender
entry so that it does not get lost, even better if a check box could be
added to the alarm dialog so the user can manipulate it.
In this mail I also included support for call_history. A change is required
to the call_history.py for this to ensure unique IDs. I think this is a
temporary patch as Joe is looking into what the problem is.
p_lgvx8100.p
I agree is makes sense to create a new lg protocol file as you suggested,
this will touch a lot of files, probably too many files for me to manage via
e-mail checkin. Can you do this once you are comfortable with my other
changes?
New code attached (incl. help) with diffs from CVS. (all updates are in this
mail, discard all others)
Simon
-----Original Message-----
From: bitpim-devel-***@lists.sourceforge.net
[mailto:bitpim-devel-***@lists.sourceforge.net]On Behalf Of Roger
Binns
Sent: Monday, August 08, 2005 9:25 PM
To: bitpim-***@lists.sourceforge.net
Subject: Re: [BitPim-devel] Updates to vx8100
Post by SimonSource attached. (com_lgvx4400.py, p_lgvx4400.p, com_lgvx8100.py,
p_lgvx8100.p)
In future please use diff -u as detailed on the developer page
http://bitpim.org/developer.html
com_lgvx4400.py:
What is the purpose of speeddialoffset? Is the 8100 doing something
bizarre like not starting the file at one? (The other phones that
use one for voicemail ignore the entry but it is there.)
I also don't like the change of the unset alarm for all LG models.
The LG calendar code does need to be redone, probably from scratch.
If you have the time and inclinatio, I would suggest doing that
and we can make values like that be model dependent.
Removing the comment doesn't remove what it states. You cannot
save to an origin of camera. Assuming the 8100 is like the 8000
and 7000, then there is no seperate origin for camera so that
is all immaterial.
com_lgvx8100.py:
You seem to have figured out the calendar on that phone. However
it seems to be reading and writing newschedule.dat. Is that
really the name of the file (ie the new prefix). It would be
great if you can document the format and we can try to get
unified improved LG calendar support. Unless the format is
completely different - ie new :-) You can save it in analyser
format to make life easy.
It also looks like you can seperately set the alarm for a
calendar event to vibrate. Is that in addition to the
ringtone? Anyway it seems like you give vibrate special
treatment. My concern is that if a user read their calendar
into BitPim and then wrote it back out, the vibrate information
would be stripped. Post here what semantics you need (eg is
vibrate just another ringtone or is it a flag) and Joe can
provide a solution to preserving the value.
p_lgvx4400.p:
Just awaiting the speed dial clarification.
p_lgvx8100.py:
That class needs to go into a seperate file. We'll start a
file named prototypeslg.py for the LG protocol specific types
(LGCALDATE can also be pulled out of prototypes.py). (BTW
prototypes is short for protocol types not the C header sense).
------
I have merged any of the above yet, awaiting your feedback ...
Roger
-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf