Discussion:
[BitPim-devel] 0.7.28 available to test
Roger Binns
2005-03-08 08:24:24 UTC
Permalink
http://sf.net/project/showfiles.php?group_id=75211&package_id=120233&release_id=311141

Please especially verify the new image sizing code.

Adit, can you confirm the new Memo tab looks correct on Mac? It looks totally
hideous to me, but then so do all metal apps. BTW your changes from this
evening aren't in the build as I had already started it.

If everything is good, I'll announce this tomorrow (Tuesday) evening.

Roger
Adit Panchal
2005-03-08 08:52:18 UTC
Permalink
I know it doesn't look pretty, but the toolbar looks even worse than
the Memo tab. I compared the tab to the Windows one, and it looks
basically the same to me. Maybe the listboxes can be stretched to fill
the contents? Any specific comments to what doesn't look right? (The
fact that it is all metal and doesn't have any warmth to it ;)

The image sizing code works fine here (Mac OS X 10.3.8, SCP-5500).
Build looks good to me.

I am still making changes to the update I submitted. I figured out that
there is no need to verify whether an item has been selected. I made it
easier by making sure when a new contact is created, the name text box
is focused/selected. This way, the pre-existing code already checked
for this condition (focus), so it should solve the problem by itself.
Unfortunately, this fixes things on the Mac, but for some reason, I
can't get it to focus on the text box on Windows.

Adit
d***@netzero.com
2005-03-08 14:55:02 UTC
Permalink
Roger, just committed an update to the check-for-update stuff, if you don't mind doing another quick build. Everything else looks good. How do you want to handle updating the 'updates.xml' file once the latest load is available? One way we could do it is that I would make changes to the file, commit it back, and then you would sync it.

-Joe Pham


______________________________________________________________________
Speed up your surfing with NetZero HiSpeed.
Now includes pop-up blocker!
Only $14.95/month -visit http://www.netzero.com/surf to sign up today!
Stephen Wood
2005-03-08 15:24:16 UTC
Permalink
If there is going to be a rebuild, could we wait until tonight? I
think it is OK, but I just want to make sure that BitFling works, as
built, to serve up a phone on Windows. I won't be able to be able to
do that test until this evening.

Thanks, Stephen
Post by d***@netzero.com
Roger, just committed an update to the check-for-update stuff, if you don't mind doing another quick build. Everything else looks good. How do you want to handle updating the 'updates.xml' file once the latest load is available? One way we could do it is that I would make changes to the file, commit it back, and then you would sync it.
-Joe Pham
Roger Binns
2005-03-08 17:02:04 UTC
Permalink
Post by d***@netzero.com
if you don't mind doing another quick build.
Errrm, you are aware that doing builds is time consuming and tedious?

This time I will do it and also wait for Stephen's change. In future
rebuilds will only be done if there are serious problems. We have one
every two weeks so there is no need to try and make one perfect.
Post by d***@netzero.com
How do you want to handle updating the 'updates.xml' file once the latest
load is available? One way we could do it is that I would make changes
to the file, commit it back, and then you would sync it.
Yes. Once a release announcement goes out, update the file.

Generally whenever anyone updates anything in the bpweb module I do an
update within 24 hours.

Roger
Stephen Wood
2005-03-08 17:18:02 UTC
Permalink
Post by Roger Binns
Post by d***@netzero.com
if you don't mind doing another quick build.
Errrm, you are aware that doing builds is time consuming and tedious?
This time I will do it and also wait for Stephen's change. In future
rebuilds will only be done if there are serious problems. We have one
every two weeks so there is no need to try and make one perfect.
I don't expect to make a change. I just want a chance to test out the
build before it is announced, especially if a new build is going to be
done anyway. If BitFling is working in the build (which I think it
is, but I just want to make sure), then I'll be able to start cleaning
up the code for the Sanyo MM-7400.

Stephen
Roger Binns
2005-03-08 17:34:06 UTC
Permalink
Post by Stephen Wood
I don't expect to make a change. I just want a chance to test out the
build before it is announced, especially if a new build is going to be
done anyway.
Let us know when you are done ...
Post by Stephen Wood
then I'll be able to start cleaning up the code for the Sanyo MM-7400.
BTW what is so special/different about that particular model?

Roger
Stephen Wood
2005-03-08 17:54:29 UTC
Permalink
Post by Roger Binns
Post by Stephen Wood
then I'll be able to start cleaning up the code for the Sanyo MM-7400.
BTW what is so special/different about that particular model?
It is the usual story of things changing slightly with each model. In
previous models I was able to figure things out from a few protocol
traces. Perhaps the additional header words got added, or the sizes
and locations of fields got shifted around. With this phone, some
fields (like the flag that indicates if a calendar entry is in use)
are gone. I have an idea where some of them may have gone, and
BitFling gives the ability to rapidly try out these ideas. Also, the
MM-7400 is the first Sanyo phone that puts media into the filesystem.
Hopefully the next phone from Sanyo, the 5600, will be similar to this
one.

Stephen
Roger Binns
2005-03-09 07:00:09 UTC
Permalink
Post by Stephen Wood
traces. Perhaps the additional header words got added, or the sizes
and locations of fields got shifted around. With this phone, some
fields (like the flag that indicates if a calendar entry is in use)
are gone.
For the LG models, data has been consolidated over time. For example
the vx6000 had 4 seperate locations that images could be placed. The
vx7000 is down to one.

They have also been dumbing down the user interface. The models prior
to the vx7000 had around 10 different phone number types. It is down
to 6 for the vx7000.

I should be getting the vx8000 in the next few days so it will be
interesting to see what that does.

Roger

Stephen Wood
2005-03-09 01:06:02 UTC
Permalink
Post by Roger Binns
Post by Stephen Wood
I don't expect to make a change. I just want a chance to test out the
build before it is announced, especially if a new build is going to be
done anyway.
Let us know when you are done ..
BitFling serving works well enough, for my purposes, in the current
build 0.7.28 build, so I have no changes.

Just as a note, BitFling from the 0.7.28 build pops up a help screen
when you start it and the taskbar button is just a ?? (mix between
purple and pink) square with no paw print. When I run from CVS, I get
no help screen and I get the BitFling icon. (On my CVS I am using the
latest wxPython beta if that makes a difference).

Also, for this build, BitFling is not usable as a client, because I
havn't added sendatcommand to BitFling and sendatcommand is used in
com_brew. It's not a problem for me or anyone running from CVS as the
code fragment with sendatcommand can just be commented out. (It is a
check to try to prevent the A700 from going into diagnostic mode.
With the return to modem mode option in the file system browser, I
could probably remove this check for the A700, but there is still so
much mythology about locked up phones and firmware releases that I am
reluctant.)


Stephen
Roger Binns
2005-03-09 05:14:52 UTC
Permalink
Post by Stephen Wood
Just as a note, BitFling from the 0.7.28 build pops up a help screen
when you start it
That is a bug in wxWidgets. The help will have issues anyway since
I changed to only CHM a while back. I'll fix it for the next build
(the code in the main gui.py needs to be copied).
Post by Stephen Wood
When I run from CVS, I get
no help screen and I get the BitFling icon. (On my CVS I am using the
latest wxPython beta if that makes a difference).
The lack of help in the binary is probably causing an exception and
aborting the constructor.

Roger
d***@netzero.com
2005-03-08 15:35:48 UTC
Permalink
I just made some minor spacing improvements to the memo tab panel. Adit, when you get a chance, please check it out and post a Mac screenshot.

Thanks,

-Joe Pham



______________________________________________________________________
Speed up your surfing with NetZero HiSpeed.
Now includes pop-up blocker!
Only $14.95/month -visit http://www.netzero.com/surf to sign up today!
Adit Panchal
2005-03-08 19:11:11 UTC
Permalink
Well the listbox for the memos has increased in size. I don't think
that needed to be changed, as the previous size was large enough to
accommodate the memo names. Additionally, now when you shrink the
window, the vbs1 sizer gets pushed over the listbox (as can be seen in
the 2nd screenshot).

I think the best way to solve the problem is to increase the size of
the category manager sizer, vertically, so that it occupies more space
relative to the memo text. The memo text should be a fixed size. Since
it has a scrollbox, there shouldn't be any problems with shrinking it.

Is there any accurate way to patch my copy of the cvs with a diff from
cvs-checkins? The delay is rather long and I have to make changes line
by line - I am not 100% sure that I got every change.

Thanks,

Adit
Adit Panchal
2005-03-08 20:19:54 UTC
Permalink
I figured it out. Just make the category sizer more percentage - I
changed the value from 0 to 1. Also to fix the overlapping text, the
memo listbox sizer should be reduced to 0 from 1. This is all in
MemoWidget.

Screen shot is attached.

Index: memo.py
===================================================================
RCS file: /cvsroot/bitpim/bitpim/memo.py,v
retrieving revision 1.5
diff -u -r1.5 memo.py
--- memo.py 8 Mar 2005 15:29:35 -0000 1.5
+++ memo.py 8 Mar 2005 20:17:22 -0000
@@ -254,12 +254,12 @@
# the list box
self.__item_list=wx.ListBox(self, wx.NewId(), size=(300,-1),

style=wx.LB_SINGLE|wx.LB_HSCROLL|wx.LB_NEEDED_SB)
- hbs.Add(self.__item_list, 1, wx.EXPAND|wx.BOTTOM, border=5)
+ hbs.Add(self.__item_list, 0, wx.EXPAND|wx.BOTTOM, border=5)
# the detailed info pane
vbs1=wx.BoxSizer(wx.VERTICAL)
self.__items=(
(GeneralEditor, 0),
- (cal_editor.CategoryEditor, 0),
+ (cal_editor.CategoryEditor, 1),
(pb_editor.MemoEditor, 1)
)
self.__w=[]


Thanks,

Adit
John P Speno
2005-03-08 15:44:24 UTC
Permalink
Post by Roger Binns
Adit, can you confirm the new Memo tab looks correct on Mac? It looks totally
hideous to me, but then so do all metal apps. BTW your changes from this
evening aren't in the build as I had already started it.
That memo tabs looks good, but the Master Category listbox is too small to fit
the arrows in the scrollbar, at least with my non-default setting. I have both
up and down arrows at both ends of the scrollbar. :-)

The other issue I've noticed is in the PhoneBook, Wallpaper and Ringers tab. In
all tabs, I can't click to select anything.

However, if I first click the 'Remove' button in the toolbar, after that I can
click to select things in any tab.
Adit Panchal
2005-03-08 19:19:43 UTC
Permalink
Post by John P Speno
That memo tabs looks good, but the Master Category listbox is too small to fit
the arrows in the scrollbar, at least with my non-default setting. I have both
up and down arrows at both ends of the scrollbar. :-)
I get the same issues with the Master Category listbox. See my
screenshots in the previous message. I am assuming that is what you are
getting as well?
Post by John P Speno
The other issue I've noticed is in the PhoneBook, Wallpaper and Ringers tab. In
all tabs, I can't click to select anything.
However, if I first click the 'Remove' button in the toolbar, after that I can
click to select things in any tab.
I did not notice this problem. Does this issue affect the Memo tab as
well? About how many items did you have in each tab? I will try to look
into it and see if I can reproduce it.

Adit
John P Speno
2005-03-08 20:26:45 UTC
Permalink
Post by Adit Panchal
I get the same issues with the Master Category listbox. See my
screenshots in the previous message. I am assuming that is what you are
getting as well?
Yea, that's what I'm complaining about.
Post by Adit Panchal
Post by John P Speno
The other issue I've noticed is in the PhoneBook, Wallpaper and Ringers tab. In
all tabs, I can't click to select anything.
However, if I first click the 'Remove' button in the toolbar, after that I can
click to select things in any tab.
I did not notice this problem. Does this issue affect the Memo tab as
well? About how many items did you have in each tab? I will try to look
into it and see if I can reproduce it.
I have 1 wallpaper and ringer each. I have a few dozen phonebook enties.

It just seems BitPim doesn't like to accept my mouse clicks. If I have its
window in the background, I can't click on it to bring it to the front, but a
double click will minimize it. Very odd. Tested that on two different 10.3.8
systems and got same results.

And no, it doesn't affect the memo tab.

However, while playing with the memo tab, I got this exception when I clicked
on the name of a memo in the list on the left:

Traceback (most recent call last):
File "memo.pyo", line 422, in __OnListBoxItem
File "memo.pyo", line 339, in __populate_each
File "phonebookentryeditor.pyo", line 486, in Set
File "wx/_controls.pyo", line 1634, in SetValue
TypeError: String or Unicode type required

Variables by last 8 frames, innermost last

Frame ? in /Volumes/BitPim/BitPim.app/Contents/Resources/Python/bp.py at line 79
profile = <function profile at 0x21c0f0>
_run = <function _run at 0x21c0b0>
_chdir_resource = <function _chdir_resource at 0x219a70>
_disable_linecache = <function _disable_linecache at 0x2198f0>
__file__ = '/Volumes/BitPim/BitPim.app/Contents/Resources/__boot__.py'
__name__ = '__main__'
__doc__ = 'Main entry point to Bitpim\n\nIt invokes BitPim in gui or commandline mode as a

Frame run in gui.pyo at line 432
args = (['/Volumes/BitPim/BitPim.app/Contents/Resources/__boot__.py', '-psn_0_6029313']
m = <gui.MainApp; proxy of C++ wxPyApp instance at _037061c0_p_wxPyApp>

Frame MainLoop in wx/_core.pyo at line 5262
self = <gui.MainApp; proxy of C++ wxPyApp instance at _037061c0_p_wxPyApp>

Frame MainLoop in wx/_core.pyo at line 4732
args = (<gui.MainApp; proxy of C++ wxPyApp instance at _037061c0_p_wxPyApp>,)
kwargs = Keys []
{}

Frame __OnListBoxItem in memo.pyo at line 422
self = <memo.MemoWidget; proxy of C++ wxPanel instance at _073547e0_p_wxPanel>
evt = <wx._core.CommandEvent; proxy of C++ wxCommandEvent instance at _073e9520_p_wxCo

Frame __populate_each in memo.pyo at line 339
entry = <memo.MemoEntry object at 0x6f61050>
k = '1110311101.72'
self = <memo.MemoWidget; proxy of C++ wxPanel instance at _073547e0_p_wxPanel>
w = <phonebookentryeditor.MemoEditor; proxy of C++ wxPanel instance at _0736c300_p_w

Frame Set in phonebookentryeditor.pyo at line 486
s = None
data = Keys ['memo']
{'memo': None}
self = <phonebookentryeditor.MemoEditor; proxy of C++ wxPanel instance at _0736c300_p_w

Frame SetValue in wx/_controls.pyo at line 1634
args = (<wx._controls.TextCtrl; proxy of C++ wxTextCtrl instance at _0736e110_p_wxTextC
kwargs = Keys []
{}
d***@netzero.com
2005-03-08 21:12:38 UTC
Permalink
Post by John P Speno
However, while playing with the memo tab, I got this exception when I
Thanks for reporting the problem. It's been corrected just in time for this build.

-Joe Pham



______________________________________________________________________
Speed up your surfing with NetZero HiSpeed.
Now includes pop-up blocker!
Only $14.95/month -visit http://www.netzero.com/surf to sign up today!
Loading...