wrt the counting scheme, Stephen suggested, and I didn't disagree with him, that we should not rely on the internal counter, which is non-portable and can be corrupted, and instead just read all available slots. Obviously, this would take a tad longer but would also be more reliable and more portable.
wrt the name length, I did put in a check for that and other conditions of a valid phone entry. However, instead of truncating the name, I just flag it as an invalid entry and display it to the user without sending any phonebook data to the phone, ie. all entries must be valid to be sent to the phone.
Both the Samsung A650 and A310 code are ready for a development build. Vic, I don't have an A670, but please let me know what I can do to help.
-Joe Pham
Post by Roger BinnsMy egroupware stuff is ready for the build. Please let me know
when the Samsung stuff is in a good enough shape. (You can
put "if __debug__" around bits you don't want exposed in the build).
The versionhistory (at least) needs updating for the Samsung stuff
as well. I'd also be happy to start the help pages. The main
decision is if you want one page set for each model (like the LG
help) or a single page set for all models (like Sprint Sanyo). I
guess that depends on how much the models are (gratuitiously?)
different
from each other.
I noticed the cvs version of the Samsung a670 seems to have a revised
phone number counting scheme that I did not personally add. But it does
not have the wallpaper download stuff that I added and sent to Stephen.
I don't believe it has a revised phonebook write routine that limits
string lengths to the allowed values. I was waiting to see what Joe
came up with for the A650. If a build is done it probably should
include such a fix or else the line in _supportedsyncs:
('phonebook', 'write', 'OVERWRITE'), # only overwriting
phonebook
should be commented out. (It is probably not a good idea to release
something that will corrupt a user's phonebook if they type a name that
is too long into BitPim.)
A note about the new counting scheme: I hope I did not unnecessarily
sound an alarm about the mysterious entry count returned by AT#PCBIT?.
As I said before, the old scheme actually seems to work on a
non-corrupted phonebook. The new scheme takes a little longer. I had
thought maybe we could just read entries until we hit a blank one but
clearly deleting an entry leaves a blank slot until you add another new
one. (It seems a shame to have to run through all 500 of my entry slots
to find the 43rd and last entry in my phonebook just because I happened
to have deleted one of the first 42. Oh well.)
Vic
-------------------------------------------------------
This SF.Net email is sponsored by:
Sybase ASE Linux Express Edition - download now for FREE
LinuxWorld Reader's Choice Award Winner for best database on Linux.
http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click
_______________________________________________
Bitpim-devel mailing list
Bitpim-***@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bitpim-devel
________________________________________________________________
Speed up your surfing with NetZero HiSpeed.
Now includes pop-up blocker!
Only $14.95/ month - visit http://www.netzero.com/surf to sign up today!